check_amavis

In general this script works fine. Thanks for the effort of making this for the community.

There is some minor room for improvement though which a wanted to share.

The nagios embedded perl interpreter (can be switched on/off) runs check commands with use strict.

So at line 28 the "$result =" should be "my $result =", otherwise use strict (of the embedded perl) will fail.

But if the above is changed it clashes with "my $result =" on line 79 . This should be changed to something like "my $smtp_result =". The $result at line 82 and 86 should be changed accordingly.

The regexp at line 82 only catches if amavis is configures with "$final_virus_destiny = D_DISCARD" or "$final_virus_destiny = D_ACCEPT". It fails in case of "$final_virus_destiny = D_REJECT".

An alternative for rule 82 might be:

if ( $smtp_result =~/2.7.[01] Ok, discarded/ or $smtp_result =~/5.7.[01] Reject, id=/ ) {

Or even better perhaps to:

if ( $smtp_result =~ /INFECTED:sEicar-Test-Signature/ ) {

Just a few thoughts for improvement.

Thanks again for the effort.

Plugin works fine, but can´t detect if clamav (or any other is down)

I have added timeout to the smtp connection, if clamav is down, amavis holds for 15 seconds, using timout can detect it:

my $smtp = new Net::SMTP(
$server,
Port => $port,
Debug => $debug,
Timeout => $timeout
);

There is a bug if the server is unreachable.
The plugin will print CRITICAL but the exit code is still 0 so Nagios will think the status is ok.
You should use exit 2;


if (!$smtp) {
print "CRITICAL - amavisd-new server unreachable
";
exit 2;
}

Besides that the plugin works great.

I needed to change the result from 2.7.1 to 2.7.0 and I added the exit 1; otherwise the state won't change in nagios. thanks for this script!

if ($result =~/2.7.0 Ok, discarded/) {
print "OK - All finen"
} else {
print "CRITICAL - amavisd-new returned $result";
exit 1;
}