Windows time check against NTPD (check_time.vbs)

Script may be used to compare sub=seconds offsets but it should be patched for correct work:

1) SetLocale("en-us") should be added as mentioned above

2) Abs() should be used then comparing, around 75th line:

If result = "" Then
Err = 3
Status = "UNKNOWN"
ElseIf Abs(result) > Abs(crit) Then
Err = 2
status = "CRITICAL"
ElseIf Abs(result) > Abs(warn) Then
Err = 1
status = "WARNING"
Else
Err = 0
status = "OK"
End If

---

This script runs fine and works properly but every once in a while it returns this error-

The command (cscript.exe //T:30 //NoLogo scriptscheck_time.vbs 10.210.26.221 +5 +10) returned an invalid return code: 128

I can't see anything wrong in the script itself... has anyone had a similar problem?

---

I am running into an issue with this script on Server 2008 R2. When I run the script it errors out on line 53 where it runs the following:

If myMatches(0).SubMatches(0) "" Then
result = myMatches(0).SubMatches(0)
End If

Has anyone else experienced this issue and/or know how to work around this?

---

I just and :

SetLocale("en-us")

at the top of script for server with specific number format (2008R2, us, with french number format)

The PhilS second point seems to be true

---

Good script seems to work!

However another couple of points:

1. The /nowarn option of w32tm.exe looks like it's not supported in earlier versions of Windows including XP, but is supported in Vista,7, 2008 Server etc. So for these you need to remove this option from the following line, otherwise the script returns an error.

strCommand = "%SystemRoot%System32w32tm.exe /monitor /nowarn /computers:" & serverlist



2. Further to the points made abut the thresholds not working correctly, can I suggest you make the following change:

Change the statement

If result = "" Then
Err = 3
Status = "UNKNOWN"
ElseIf result > crit Then
Err = 2
status = "CRITICAL"
ElseIf result > warn Then
Err = 1
status = "WARNING"
Else
Err = 0
status = "OK"
End If

to the following:

If result = "" Then
Err = 3
Status = "UNKNOWN"
ElseIf abs(result) > abs(crit) Then
Err = 2
status = "CRITICAL"
ElseIf abs(result) > abs(warn) Then
Err = 1
status = "WARNING"
Else
Err = 0
status = "OK"
End If

Then it seems to work properly as far as I have tested it and you can supply the thresholds unsigned.

Regards
Phil

---

Hi! great script!

a couple of things:

1) the line (near the end):

Wscript.Echo "NTP " & status & ": Offset " & result & " secs|'offset'=" & result & "s;" & warn & ";" & crit & ";"

should be changed in:

Wscript.Echo "NTP " & status & ": Offset " & result & " secs|offset=" & result & "s;" & warn & ";" & crit & ";"

so the performance data can processed by pnp4nagios addon.



2) I think there's a problem with warning and critical thresholds... arguments must contain + and - signs...

for example, this works:
cscript.exe //T:30 //NoLogo scriptscheck_time.vbs 10.65.0.100 +5 +10
NTP CRITICAL: Offset +62.0905029 secs|offset=+62.0905029s;+5;+10;

this doesn't:
cscript.exe //T:30 //NoLogo scriptscheck_time.vbs 10.65.0.100 5 10
NTP OK: Offset +62.0866201 secs|offset=+62.0866201s;5;10;


best regards, Federico

---