Isaac Witmer

Too many comments not enough functionality

It seems strange that half of the script is just comments. I replaced it with this script: #!/usr/bin/perl -w use strict; use Getopt::Long; use constant { OK => 0, WARNING => 1, CRITICAL => 2, UNKNOWN => 3 }; use constant RETCODES => qw ( OK WARNING CRITICAL UNKNOWN ) ; use File::Temp qw/ tempfile tempdir /; sub error { my ($rc,$msg)=@_; printf "%s: %s ",(RETCODES)[$rc],$msg; exit($rc); } my $dir; if($ARGV[0]){ $dir = $ARGV[0]; }else{ error(UNKNOWN,"No input, specify a directory") } my $tmp = File::Temp->new( DIR => $dir ); chdir $dir or error(CRITICAL,"Could not cwd to $dir"); open FOUT,"> $tmp" or error(CRITICAL,"Could to write to $dir"); close FOUT; printf "OK: $dir is writable. "; exit(OK);

Reviewed 13 years ago

HPSA Driver

Seems silly you have to submit a review in order to communicate with the developer, ah well. It doesn't appear that any of the three drivers are available on our system: HPPROC="/proc/driver/cciss/cciss" HPSCSIPROC="/proc/scsi/scsi" COMPAQPROC="/proc/driver/cpqarray/ida" However, the program 'hpacucli' seems to work correctly. I suspect it has something to do with the fact that we don't need the cciss drivers anymore but are using hpsa (/sys/module/hpsa/) If this is something you'll fix, then I'll wait for an update, otherwise I'll patch it locally, perhaps by ripping out the checks.

Reviewed 11 years ago